Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22310 Revert now obsolete autoconf bug workaround for echo #3029

Merged
merged 2 commits into from
Jun 13, 2024
Merged

ICU-22310 Revert now obsolete autoconf bug workaround for echo #3029

merged 2 commits into from
Jun 13, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Jun 6, 2024

This workaround was originally added for ICU-7768 by commit bf92ba0.

Finding the correct ways to invoke echo is a standard feature of autoconf and works as expected at least since version 2.69:

https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Preset-Output-Variables.html

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22310
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@roubert roubert requested a review from srl295 June 13, 2024 12:18
srl295
srl295 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The break-neck pace of modern progress.. what will we see next ??

@roubert
Copy link
Member Author

roubert commented Jun 13, 2024

what will we see next ??

city of the future

@roubert roubert merged commit 6a24e8d into unicode-org:main Jun 13, 2024
97 checks passed
@roubert roubert deleted the 22310-echo branch June 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roubert @srl295